Update managed_switch.go#282
Closed
33k-org wants to merge 2 commits intoprometheus-community:mainfrom
Closed
Conversation
in order to get switch data after v. 7.2 you need to edit “managed_switch.go” to look like this: “api/v2/monitor/switch-controller/managed-switch/status”
|
Hi, would appreciate if this PR could be approved since I've the same issue with v. 7.2 and this will be the fix |
maos999
approved these changes
Oct 21, 2024
antnsn
reviewed
Oct 21, 2024
Contributor
antnsn
left a comment
antnsn
left a comment
There was a problem hiding this comment.
will work for new firmware, unsure how this work with earlier firmware?
Contributor
|
with 6.4 (last version that will break with this change) going end of everything 2026-03-31 i think we should just merge it and risk braking ancient devices that are no longer supported, in favour of current systems. |
Contributor
|
closing in favour of #324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to get switch data after v. 7.2 you need to edit “managed_switch.go” to look like this: “api/v2/monitor/switch-controller/managed-switch/status”